Skip to content

feat(desktop): harden conversion workflow - #46

Open
imadreamerboy wants to merge 6 commits into
mainfrom
codex/desktop-hardening
Open

feat(desktop): harden conversion workflow#46
imadreamerboy wants to merge 6 commits into
mainfrom
codex/desktop-hardening

Conversation

@imadreamerboy

Copy link
Copy Markdown
Owner

Summary

Hardens the desktop conversion workflow and aligns supporting documentation and dependency notices.

Why

Improve conversion reliability, prevent accidental loss of unsaved results, and make exported Markdown assets safer to replace.

Key Changes

  • Stream conversion results into the UI with retry and cancellation safeguards.
  • Use transactional Markdown and asset writes, preserving existing files on failures.
  • Add unsaved-result confirmation, update-notification controls, and supporting QML coverage.
  • Clarify licensing and third-party notices.

Testing

  • uv sync --extra test --locked && QT_QPA_PLATFORM=offscreen uv run pytest -q — 265 passed.
  • Clean merge simulation with origin/main; merged tree test suite — 266 passed.
  • Merged-tree QML load smoke — 11 passed.

Breaking Changes

None

Follow-ups

Run platform release-package builds before publishing a release.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e14d1b36bb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread markitdowngui/ui_qml/controller.py Outdated
Comment thread markitdowngui/core/markdown_assets.py Outdated
Comment thread markitdowngui/qml/Main.qml

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b91d2bf4ba

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread markitdowngui/ui_qml/controller.py
Comment thread markitdowngui/ui_qml/controller.py Outdated
Comment thread markitdowngui/core/file_utils.py
Comment thread markitdowngui/core/file_utils.py Outdated
Comment thread markitdowngui/core/markdown_assets.py Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fa48f713bd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread markitdowngui/core/markdown_assets.py
Comment thread markitdowngui/ui_qml/controller.py Outdated
Comment thread markitdowngui/ui_qml/controller.py Outdated
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant