Repository navigation
Add SASL EXTERNAL and certificate enrollment - #47
Merged
Merged
Conversation
The IRC TLS listener can ask for a client certificate without requiring one, and NickServ binds that handshake fingerprint to an existing account. PLAIN keeps working, password changes leave certificates in place, and removing a certificate only affects the next login. HTTPS does not request a client certificate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CERT LIST/CERT ADD/CERT DELenroll and revoke those fingerprints on an existing account.CERT ADDuses the certificate on the current TLS session.Fixes #45
Fixes #46
Test plan
cargo test -- --test-threads=1CAP LS 302advertisessasl=PLAINonly