Repository navigation
Stop banned and kicked users from speaking - #44
Merged
Merged
Conversation
A channel ban was checked only at JOIN, and +n rejected every sender instead of outsiders. Kick removed the nick, but PRIVMSG still reached the channel, so a flood ban did not stop the lines. Speech now honors +b (unless +e), and +n, +m, and +i apply to sending the same way they do on other ircds. A refused line is not relayed to a linked server. NOTICE stays silent on the refusal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
+bmask now blocksPRIVMSGandNOTICE, not onlyJOIN.+estill overrides it. This is what let biff keep talking in#lobbyafter eggbot banned and kicked him: the nick left the names list, and the messages were delivered anyway.+nblocks people who are not in the channel. Members can still speak. Previously+nwould have silenced everyone, including ops.+mand+iuse the same send check. A refusedPRIVMSGis404;NOTICEstays silent. A refused line is not relayed to a linked server.Test plan
cargo test --release --locked -- --test-threads=1(0 failed; ircv3 now 29, includingban_and_kick_stop_channel_messages)