Skip to content

Pipeline config parser: in absence of prior on parameter, create ufloat with std_dev of NaN, not 0 #918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thehrh merged 1 commit into from
Mar 27, 2026
Merged

Pipeline config parser: in absence of prior on parameter, create ufloat with std_dev of NaN, not 0 #918

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions pisa/utils/config_parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,7 @@
from collections import OrderedDict
from collections.abc import Mapping
from io import StringIO
import math
from os.path import abspath, expanduser, expandvars, isfile, join
import re
import sys
Expand Down Expand Up @@ -268,7 +269,7 @@

__author__ = 'P. Eller, J. Lanfranchi'

__license__ = '''Copyright (c) 2014-2025, The IceCube Collaboration
__license__ = '''Copyright (c) 2014-2026, The IceCube Collaboration

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -326,6 +327,10 @@ def parse_quantity(string):
>>> print(quant.std_dev)
0.7

>>> quant = parse_quantity('5 * units.gigametric_ton')
>>> print(quant.std_dev)
nan

Also note that spaces and the "*" are optional:

>>> print(parse_quantity('1+/-1units.GeV'))
Expand All @@ -341,7 +346,9 @@ def parse_quantity(string):
if '+/-' in value:
value = ufloat_fromstr(value)
else:
value = ufloat(float(value), 0)
# Assign a std. dev. of NaN rather than 0 (see uncertainties user guide
# on handling NaN)
value = ufloat(float(value), float("nan"))
value *= ureg(unit)
return value

Expand Down Expand Up @@ -552,7 +559,7 @@ def parse_param(config, section, selector, fullname, pname, value):
else:
raise Exception('Prior type unknown')

elif hasattr(value, 'std_dev') and value.std_dev != 0:
elif hasattr(value, 'std_dev') and not math.isnan(value.std_dev):
kwargs['prior'] = Prior(kind='gaussian',
mean=value.nominal_value * value.units,
stddev=value.std_dev * value.units)
Expand Down