Conversation
JanWeldert
marked this pull request as ready for review
February 20, 2026 09:43
thehrh
requested changes
Feb 20, 2026
thehrh
left a comment
thehrh
left a comment
Collaborator
There was a problem hiding this comment.
Please render your code more maintainable and reviewable by adding appropriate comments and docstrings (see my various inline comments). Right now, it is hard to impossible to judge whether the service is doing what it is intended to.
thehrh
reviewed
Feb 25, 2026
| container.representation = self.apply_mode | ||
| container["weights"] = hist | ||
| for k in container.validity["weights"]: | ||
| # Histogramming does not invalidate other representations. |
Collaborator
There was a problem hiding this comment.
Ok, because setting an item of a container (i.e. in this case the statement container["weights"] = hist) results in a call of mark_changed("weights"), which invalidates the "weights" in the "events" representation (or any other), even though the histogramming operation doesn't mathematically invalidate them.
thehrh
reviewed
Feb 25, 2026
thehrh
reviewed
Feb 25, 2026
thehrh
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First draft of a stage applying detector systematics by splitting snowstorm simulation in halves and extracting (linear) gradients from the two halves. It accepts snowstorm simulation where the detector systematics are sampled uniformly and from a Gaussian (the only two existing options).