[minor] Avoid generating DRO GitOps resources when DRO specs are not configured#2433
Open
nikitakumble wants to merge 4 commits into
Open
[minor] Avoid generating DRO GitOps resources when DRO specs are not configured#2433nikitakumble wants to merge 4 commits into
nikitakumble wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue
https://jsw.ibm.com/browse/MASCORE-10911
Description
This PR updates the provisioner logic to skip generating DRO-related GitOps resources when DRO specifications are not defined in
cluster-params.Previously, DRO files were generated even for MCSP provisioner clusters where no DRO specs were configured. With this change, DRO resources are generated only when the corresponding DRO configuration is present.
Changes
Added a
dro_enabledparameter to the Tekton pipeline.Set
dro_enabledbased on the presence of theibm_droconfiguration incluster-params.yamlfromsaas-envs.Testing
Tested both scenarios: verified that
gitops-dro.yamlis generated only whenibm_drois defined incluster-params.yamland is skipped otherwise.Related PR
https://github.ibm.com/maximoappsuite/saas-tekton/pull/258