Mission tab + geo and bio count on nav planets#86
Conversation
Thank you, I love this! I'd actually seen your fork a while back (just while browsing) and was excited about it and kept meaning to reach out, but also wasn't in a hurry to bother you about it. Thanks for raising it! Yeah I'd absolutely merge this in. I'd be happy to spend a bit of time seeing how much work it is to make it look like how they appear in game, and maybe include the power play assignments.
Love this too <3
👍 🙏 PS: If refactoring is a pain, I'm happy for you to raise a a PR clone the branch and I can burn a few tokens getting GitHub co-pilot wrangle any changes if things have diverged enough to make rebasing annoying. |
|
Think if you don't want to merge this into main straight away before doing some more changes and improvements, then the easier option then faffing around with new PRs is if you do a branch out of main on your end and just change destination on this PR to that. Then finalize it in there. Initially I didn't want to call the tab just "missions" I wanted to do something like a "captain/pilot log" with more things in it then just missions. But I couldn't come up with a name that wouldn't collide with the "log" tab after :D .... so it looked weird when there was two tabs called "log". I'm bringing this up because if you want power play stuff in there then it would be cool if the entries are separated. In something like a "captains log" you could have other sub tabs, so for example one with missions and one with power play assignments and potentially more stuff later (so you can add to it). Because just a "mission" tab is kinda a waste of real estate for something you only use occasionally. When it comes down to making it look closer to how it looks in-game then I'm not the best "web designer" for that :). It's been many moons since I did any of that seriously. For personal and small hobby project I tend to rely on stuff like flowbite + tailwind to make stuff look good, not writing CSS :D |
Actually yeah I was thinking exactly this :) I don't hate having a new tab for this but the idea of combining it with the log view feels like a good route. I know the CSS in particular is a bit of a disaster area and that makes things harder to style. It was one of those projects where it would have been nice to have a really good design system but doing it all myself I couldn't be bothered because it would have taken so much time/effort to do that I would have lost all momentum. |
|
Hmm if you want I could try to get tailwind and flowbite in too. It would get rid of all your components and give you much more of them on top of that. Plus it would also reduce the code size by a lot cuz you wouldn't need all that messy raw HTML and CSS. All you need is a theme so the look of the components stays the same as is now. I have experience with that It'll just take some time to do. But you'll have a much easier life after :) |
I've had this done a couple years ago. But then kinda stopped playing ED for a bit and left it. I recently started playing a bit more and seems that this still works. So I figured I might as well get it here maybe more people would find this useful then just me.
There are two things here. The main thing being a mission tab that has information about active missions from bulletin boards. The detailed info is kinda crude it just dumps the whole JSON object in there and cleans it up so it's more user friendly to read.
The other addition is on nav list panel I added a superscript number next to the planet icon. Which displays number of bio and geo signals after an FSS.
BONUS ADDITION:
There is a github action because I'm lazy doing manual builds and you don't have one :D ... it'll build every time a push to main happens and creates a release out of the build with a tag. It'll only be successful if version number in package.json is increased.
If you want to see it in action and test it the release on my fork is updated and available.
I'm not sure if any of this is inline of what Icarus wants to be but hey take it or leave it I just did this for myself :)