Skip to content

TODO list #31

Description

@zguesmi

Must have for the audit:

  • Fix AllowSkipCheck for upgrade
  • Liquidity unifier on L1
  • Add approveAndCall
  • SafeERC20
  • Use OZ ERC20Bridgeable
  • Update deployment scripts
  • Update send scripts (Send on Testnets)
  • Stargate compatibiliy draft PR
  • Update README
  • Check list document
  • Update Ownable functions
  • Optimizer/Compiler config
  • Verification scripts

  • Make Upgrade script parameterisable instead of using "IexecLayerZeroBridgeV2Mock.sol:IexecLayerZeroBridgeV2" and hardcoded newStateVariable: newStateVariable
  • Move env variable from env file to config.json file (save contract deployment address, ...)
  • Tests Unit:
    - Develop TODO in the code
    - make some unit test for script files
    - Add unit tests for _credit and _debit ✅
    - Check non covered functions
    - add missing IexecLayerZeroBridgeScript tests
  • Tests e2e:
    - Make a transfer between two fork chains (good receiver, good amount, ...)
    - move fork from testnet to mainnet
  • Tests Fuzzing:
    - shared decimals https://docs.layerzero.network/v2/developers/evm/oft/quickstart#token-transfer-precision
    - lock/unlock (unit)
    - mint/burn(unit)
    - mint +burn +lock + unlock (e2e)
  • Tests Invariant (nice to have):
    - Make a transfer between two chains - supply should always be the same
  • Slither et coverage + Codecov
  • Slither check from none to something else
  • CI - Github Action deployment contract
  • CI - Setup multisig requester in Github Actions
  • Harmonize project: naming (test_xxx, ...), comments (user /**/ everywhere), ...
    - Rename tests to: test_RevertWhen_<name>_<description>
  • Test all scripts in CI pipeline.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions