Skip to content

feat: replace deprecated isTeeTask usages with requiresSgx - #665

Merged
jbern0rd merged 1 commit into
mainfrom
feature/use-requires-sgx-instead-of-deprecated-is-tee-task
Oct 31, 2025
Merged

feat: replace deprecated isTeeTask usages with requiresSgx#665
jbern0rd merged 1 commit into
mainfrom
feature/use-requires-sgx-instead-of-deprecated-is-tee-task

Conversation

@jbern0rd

Copy link
Copy Markdown
Contributor

No description provided.

@jbern0rd jbern0rd self-assigned this Oct 31, 2025
@sonarqubecloud

Copy link
Copy Markdown

@jbern0rd
jbern0rd marked this pull request as ready for review October 31, 2025 11:49
@jbern0rd
jbern0rd requested a review from Copilot October 31, 2025 14:15

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the codebase to replace the deprecated isTeeTask boolean flag with the more comprehensive TeeFramework enum, enabling better support for multiple TEE frameworks (SCONE, GRAMINE). Additionally, it updates dependencies and removes unused fields from ResultModel.

Key Changes

  • Replaced TaskDescription.isTeeTask() boolean with TaskDescription.requiresSgx() and TeeFramework enum across the codebase
  • Refactored test utilities to use OrderTag instead of boolean flags for creating test task descriptions
  • Updated iexec-commons-poco version from 5.1.0 to 5.3.1 and iexec-common from 9.1.0 to 9.2.0
  • Removed unused image and cmd fields from ResultModel builder
  • Changed test method reference from txManager.sendCall() to web3jService.sendCall()

Reviewed Changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.

Show a summary per file
File Description
gradle.properties Bumped dependency versions for iexec-commons-poco and iexec-common
TaskManagerServiceTests.java Refactored helper method to accept OrderTag instead of boolean, updated all test calls
ResultServiceTests.java Added parameterized tests for TEE frameworks, refactored to use helper method
AppComputeServiceTests.java Updated TaskDescription builder to use OrderTag and TeeFramework
ComputeManagerServiceTests.java Refactored test helper to use OrderTag instead of boolean flag
IexecHubServiceTests.java Removed unused txManager mock, updated sendCall references to web3jService
ContributionServiceTests.java Refactored to use helper method with OrderTag for creating test TaskDescriptions
TaskManagerService.java Replaced isTeeTask() calls with requiresSgx() method
ResultService.java Removed unused fields from ResultModel builder, updated isTeeTask() to requiresSgx()
AppComputeService.java Updated isTeeTask() calls to requiresSgx()
ComputeManagerService.java Updated log messages and method calls from isTeeTask to requiresSgx
ContributionService.java Refactored to use getTaskDescription().requiresSgx() instead of isTeeTask()

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jbern0rd
jbern0rd merged commit 3a28542 into main Oct 31, 2025
11 checks passed
@jbern0rd
jbern0rd deleted the feature/use-requires-sgx-instead-of-deprecated-is-tee-task branch October 31, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants