feat: replace deprecated isTeeTask usages with requiresSgx - #665
Merged
jbern0rd merged 1 commit intoOct 31, 2025
Merged
Conversation
|
jbern0rd
marked this pull request as ready for review
October 31, 2025 11:49
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the codebase to replace the deprecated isTeeTask boolean flag with the more comprehensive TeeFramework enum, enabling better support for multiple TEE frameworks (SCONE, GRAMINE). Additionally, it updates dependencies and removes unused fields from ResultModel.
Key Changes
- Replaced
TaskDescription.isTeeTask()boolean withTaskDescription.requiresSgx()andTeeFrameworkenum across the codebase - Refactored test utilities to use
OrderTaginstead of boolean flags for creating test task descriptions - Updated
iexec-commons-pocoversion from 5.1.0 to 5.3.1 andiexec-commonfrom 9.1.0 to 9.2.0 - Removed unused
imageandcmdfields fromResultModelbuilder - Changed test method reference from
txManager.sendCall()toweb3jService.sendCall()
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| gradle.properties | Bumped dependency versions for iexec-commons-poco and iexec-common |
| TaskManagerServiceTests.java | Refactored helper method to accept OrderTag instead of boolean, updated all test calls |
| ResultServiceTests.java | Added parameterized tests for TEE frameworks, refactored to use helper method |
| AppComputeServiceTests.java | Updated TaskDescription builder to use OrderTag and TeeFramework |
| ComputeManagerServiceTests.java | Refactored test helper to use OrderTag instead of boolean flag |
| IexecHubServiceTests.java | Removed unused txManager mock, updated sendCall references to web3jService |
| ContributionServiceTests.java | Refactored to use helper method with OrderTag for creating test TaskDescriptions |
| TaskManagerService.java | Replaced isTeeTask() calls with requiresSgx() method |
| ResultService.java | Removed unused fields from ResultModel builder, updated isTeeTask() to requiresSgx() |
| AppComputeService.java | Updated isTeeTask() calls to requiresSgx() |
| ComputeManagerService.java | Updated log messages and method calls from isTeeTask to requiresSgx |
| ContributionService.java | Refactored to use getTaskDescription().requiresSgx() instead of isTeeTask() |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
nabil-Tounarti
approved these changes
Oct 31, 2025
thewhitewizard
approved these changes
Oct 31, 2025
jbern0rd
deleted the
feature/use-requires-sgx-instead-of-deprecated-is-tee-task
branch
October 31, 2025 15:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



No description provided.