-
-
Notifications
You must be signed in to change notification settings - Fork 17
Sync Laravel updates: #58565 → #58648 #580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
a07d272
Complete console command typing and preserve supported inputs
binaryfire 845d360
Complete array type coverage and correct sorting contracts
binaryfire d25b195
Complete model appended-attribute test coverage
binaryfire 7a931bb
Use the default when clamped input is not numeric
binaryfire baea152
Complete collection contracts, fixtures and adjacent grouping
binaryfire 6113204
Remove unsupported SQL Server schema paths and restore generated-colu…
binaryfire 329d747
Complete file validation custom-message test typing
binaryfire 035fd9f
Align mailable assertion fixtures with upstream order
binaryfire bf9e807
Stop migration commands when a child operation fails
binaryfire 641040b
Handle maintenance deactivation between cache reads
binaryfire 12179e5
Complete maintenance cookie validation and usage documentation
binaryfire 95e732a
Use consistent command exit-code constants
binaryfire 777a200
Complete lazy Eloquent creation values and fix through-relation colli…
binaryfire 0e40ed9
Allow fluent string deduplication of multiple characters
binaryfire 4f1ace1
Complete notification hook coverage and fixture contracts
binaryfire cfdc5a7
Complete batch cancellation event documentation and test types
binaryfire a356387
Handle maintenance file removal during worker refreshes
binaryfire df9a48d
Propagate maintenance file read failures through HTTP middleware
binaryfire File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P2:
array<TValue>narrows this associative-array API to integer-keyed inputs in static analysis, rejecting valid calls such as['id' => '123']. Declare the parameter witharray<array-key, TValue>so string and integer keys remain supported.Prompt for AI agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keeping the existing annotation. PHPStan's
array<TValue>accepts string and integer keys; it does not implyarray<int, TValue>. A max-level check ofArr::prependKeysWith(['id' => '123'], 'user_')passes and preserves the value type. Spelling out the key type would not fix an error.