Add dex parameter to user_fills, user_fills_by_time, meta_and_asset_ctxs - #310
Open
takinanton wants to merge 1 commit into
Open
Add dex parameter to user_fills, user_fills_by_time, meta_and_asset_ctxs#310takinanton wants to merge 1 commit into
takinanton wants to merge 1 commit into
Conversation
These three Info methods were the last holdouts without a dex parameter for HIP-3 builder-deployed perp dexes, while user_state, open_orders, all_mids, and meta already support it. Defaults to "" (the first/main dex) so existing callers are unaffected. Closes hyperliquid-dex#278, hyperliquid-dex#287
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
user_state, open_orders, all_mids, and meta all take an optional
dexparameter for HIP-3 builder-deployed perp dexes. user_fills,
user_fills_by_time, and meta_and_asset_ctxs did not, so callers
tracking fills or asset metadata on a HIP-3 dex had no way to scope
the request.
This adds
dex: str = ""to all three, following the exact patternalready used elsewhere in Info, so default behavior (main dex) is
unchanged for existing callers.
Closes #278, #287