test(soroban): add mint_lock example coverage - #1985
Open
salaheldinsoliman wants to merge 1 commit into
Open
Conversation
Maps the upstream stellar/soroban-examples mint-lock example: an admin grants per-minter mint limits and minters mint through a cross-contract call into the token, reverting past their cap. Mock-VM tests (tests/soroban_testcases/mint_lock.rs) stay close to the upstream example: int128 amounts, admin.requireAuth() on set_limit and minter.requireAuth() on mint. Adaptations: the per-epoch minted-amount window is simplified to a cumulative cap, the admin is set through set_admin rather than at init, and the token mint goes through a low-level abi.encode + call rather than a typed client. The integration variant (integration/soroban/mint_lock.sol + ml_token.sol + spec) follows the existing integration conventions: auth-free (no auth mocking on the test network), uint64 amounts, and one contract per file. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: salaheldinsoliman <salaheldin_sameh@aucegypt.edu>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Maps the upstream
stellar/soroban-examplesmint-lock example (refs #1901): an admin grants per-minter mint limits; minters mint through a cross-contract call into the token and are reverted past their cap.Independent of the #1982/#1983/#1984 stack — everything here works on current
main.What's included
tests/soroban_testcases/mint_lock.rs): mint up to the limit succeeds; minting over it reverts.integration/soroban/mint_lock.sol,ml_token.sol,mint_lock.spec.js).Fidelity to the upstream example (adaptations disclosed)
The mock-VM contract stays close to upstream:
int128amounts,admin.requireAuth()onset_limit,minter.requireAuth()onmint, cross-contract token mint. Tweaks:set_adminrather than at init;abi.encode+.callrather than a typed client.The integration variant is adapted further, following the existing
integration/sorobanconventions: auth-free (no auth mocking is available against the test network),uint64amounts, no admin role, one contract per file.🤖 Generated with Claude Code