proxy: honor Windows proxy bypass macros and loopback defaults#280
Open
chitao1234 wants to merge 2 commits intohyperium:masterfrom
Open
proxy: honor Windows proxy bypass macros and loopback defaults#280chitao1234 wants to merge 2 commits intohyperium:masterfrom
chitao1234 wants to merge 2 commits intohyperium:masterfrom
Conversation
Parse Windows `ProxyOverride` entries into explicit no-proxy rules while supporting the special `<local>` and `<-loopback>` semantics. By default, preserve the system loopback bypass behavior for `localhost`, `loopback`, `127.0.0.1`, and `::1`, and add tests covering local-name and loopback matching.
seanmonstar
reviewed
Apr 23, 2026
| ips: IpMatcher, | ||
| domains: DomainMatcher, | ||
| local_names: bool, | ||
| loopback_hosts: bool, |
Member
There was a problem hiding this comment.
I'm curious, is there a reason to store additional booleans instead of just pushing localhost and the IPs to the DomainMatcher and IpMatcher?
Author
There was a problem hiding this comment.
I agree that the loopback flags can be folded, and I folded them into the windows proxy override parsing logic. However the local flags should be kept due to there not being an equivalent for it (it matches all domain names without a dot in the middle like http://intranet/).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parse Windows
ProxyOverrideentries into explicit no-proxy rules while supporting the special<local>and<-loopback>semantics.By default, preserve the system loopback bypass behavior for
localhost,loopback,127.0.0.1, and::1, and add tests covering local-name and loopback matching.Source:
https://learn.microsoft.com/en-us/windows/win32/wininet/enabling-internet-functionality
https://learn.microsoft.com/en-us/windows/win32/api/wininet/nf-wininet-internetopena