fix(ir): Preserve auto deps across dynamic loop fallback#1739
fix(ir): Preserve auto deps across dynamic loop fallback#1739sunkaixuan2018 wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe PR refines dynamic producer hazard handling in the auto-derivation task dependencies pass. When a call encounters a dynamic producer hazard inside an auto scope (not manual), fallback is now suppressed with a debug log rather than triggered. A new test validates that encodable compiler edges are preserved correctly across consume calls in dynamic loop scenarios. ChangesDynamic Producer Hazard Scoping
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 Infer (1.2.0)src/ir/transforms/auto_derive_task_dependencies_pass.cppsrc/ir/transforms/auto_derive_task_dependencies_pass.cpp:29:10: fatal error: 'pypto/codegen/orchestration/orchestration_analysis.h' file not found ... [truncated 2200 characters] ... truction_log.(fun) in file "src/clang/cTrans.ml", line 4782, characters 12-47 Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request modifies the AutoDepMutator to skip dynamic prior producers when not within a manual scope, preventing unnecessary fallback behavior. A corresponding unit test has been added to verify that encodable edges are not stripped under these conditions. There are no review comments, so no additional feedback is provided.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Summary
Testing
tests/ut/ir/transforms/test_auto_derive_task_dependencies.py -v(34 passed)Notes
.venvunder/data/sunkaixuan/all_pyptos/auto-deps-dynamic-loop-fallback-current/.venvto avoid modifying shared Python environments.