Dynamic A5 sim DSL examples#821
Open
MirkoDeVita98 wants to merge 4 commits into
Open
Conversation
Codex Review该评论由 review 机器人自动更新。
SummaryReview failed at stage Findings未生成结构化 findings，因为 review 过程提前失败。 Log Tail |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new example file, dynamic_softmax_launch.py, which demonstrates a dynamic-shape row-wise softmax launch demo using PTODSL. The feedback highlights a potential issue with using Python's built-in hash() function to seed the random number generator, as hash randomization makes it non-deterministic across different runs. A deterministic seeding approach is suggested to ensure reproducible test inputs.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| def make_case_inputs(case: dict[str, object]): | ||
| seq = int(case["seq"]) | ||
| rows = int(case["rows"]) | ||
| rng = np.random.RandomState(hash(case["name"]) & 0xFFFFFFFF) |
There was a problem hiding this comment.
Using Python's built-in hash() function on strings for seeding the random number generator is non-deterministic across different Python processes/runs due to hash randomization. This can lead to non-reproducible test inputs, making debugging flaky test failures or comparing performance runs difficult. Consider using a deterministic seed based on the case name, such as the sum of its character codes.
Suggested change
| rng = np.random.RandomState(hash(case["name"]) & 0xFFFFFFFF) | |
| seed = sum(ord(c) for c in case["name"]) | |
| rng = np.random.RandomState(seed) |
Zhendong404
reviewed
Jun 16, 2026
| pto.set_flag("MTE2", "V", event_id=0) | ||
| pto.wait_flag("MTE2", "V", event_id=0) | ||
|
|
||
| with pto.simd(): |
Contributor
There was a problem hiding this comment.
Actually you don't need pto.simd() under explicit mode
Zhendong404
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.