Repository navigation
Conversation
huntharo
force-pushed
the
perf/macos-native-metadata
branch
from
September 27, 2026 13:30
1770c58 to
cc731e6
Compare
This was referenced Sep 29, 2026
huntharo
force-pushed
the
perf/macos-native-metadata
branch
from
October 14, 2026 16:32
5c46436 to
b36bad6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main already uses
getattrlistbulkfor macOS enumeration. This change adds fallback and metadata compatibility handling to that path.When the first bulk call returns
ENOTSUP,ENOSYSorEACCES, the reader falls back tostd::fs::read_dir, preserving name enumeration and per-entry metadata errors. It never restarts after returning entries, which would duplicate part of the tree.Additional behavior:
Tests cover malformed and truncated records, omitted attributes, fallback before/after partial enumeration, permissions, timestamps, firmlink fixtures, disappearing directories, multiple buffers and accounting parity.
Validation at
b36bad6: 157 core tests passed (2 ignored), 71 app tests passed, andcargo +1.97.1 xtask lintpassed.Tradeoff and limits: the current patch replaces the macOS reader, adds a direct macOS
libcdependency and does not retain main’s per-thread buffer reuse. No performance improvement over current main has been established. Unsupported-enumeration fallback and firmlink cases include injected fixtures; a real unsupported filesystem and live evicted cloud-provider behavior remain untested.