fix: accept 0 as a valid token_count in ContextManager.add_message - #356
Open
andrewwhitecdw wants to merge 1 commit into
Open
Conversation
add_message annotated token_count as int but defaulted to None, and the guard treated 0 as unset. This meant callers could not explicitly set the running context usage to 0. Annotate token_count as int | None and check so 0 is honored. Signed-off-by: Andrew White <andrewh@cdw.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
ContextManager.add_messageannotatedtoken_countasintbut defaulted toNone, and the guardif token_count:treated0as unset. This prevented callers from explicitly setting the running context usage to zero.Fix
Annotate
token_countasint | Noneand checkif token_count is not None:so0is honored.Test
Added
tests/unit/test_context_manager.pywith a regression test that setstoken_count=0and assertsrunning_context_usagebecomes0.Verification
uv run --extra dev pytest tests/unit/test_context_manager.py -vpasses.