taking fixes from #70 - #84
Merged
Merged
Conversation
The home-indicator and pointer-lock child-VC overrides stored their mapping in static [UIViewController: UIViewController] dictionaries, which strongly retain both the parent VC (key) and the ParsecViewController (value). The teardown path clears them on viewWillDisappear, but an abnormal disconnect that skips it leaked the entire Parsec VC — GLKView, gesture recognizers, render plumbing — once per reconnect. Switch both to NSMapTable.weakToWeakObjects(): neither side is retained, so a dropped VC deallocates and its entry auto-empties even without the explicit clear. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
getVersionInfo force-unwrapped Bundle.main.infoDictionary! twice and cast its values implicitly, and carried a "Unknown versino" typo in the fallback. Read the dictionary optionally with typed `as? String` fallbacks and fix the typo. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
picking commits from @2extndd #70 and trimming a comment, rest of that pr either got overtaken by #78 or still needs splitting
@2extndd your commits land under extndd, if you move your commit email over, github should relink all of them for you to receive proper credit