Allow building the C extension on GraalPy and running tests with it.#484
Allow building the C extension on GraalPy and running tests with it.#484
Conversation
hodgestar
left a comment
There was a problem hiding this comment.
What does is mean that GraalPy no longer has its own universal module? Does it now full support this via its CPython C API? Is this a good or bad thing? :)
What is the plan for the tests that fail on GraalPy? Slowly fix them somehow?
|
The previous PR merged to main was green, and now valgrind and python2.7 is failing. What changed? |
The 2.7 is just that i added a skip using sys.implementation without guarding for 2.7 The valgrind issue seems this: https://github.com/hpyproject/hpy/actions/runs/14363896576/job/40272010157?pr=484#step:6:13 Looking into it 👀 |
|
For valgrind I opened https://github.com/hpyproject/hpy/pull/485/files |
|
#485 is in, do you want to rebase/merge to get that here? |
It's a pretty good test case for our cpyext layer :)
The nice thing is that these are pretty good small tests for our cpyext and they probably expose issues that manifest in other larger C extensions in a less reproducible way, so yes, I plan to pick at these and get them working. We used to have more working in fact, but we regressed a bit recently, but I would like to get this in sooner rather than later and continue with follow-up PRs. |
9168f4b to
e439953
Compare
|
The changes look good from my side. Happy to review again later once tests are passing. |
| @@ -1,4 +1,5 @@ | |||
| from .support import HPyTest, make_hpy_abi_fixture | |||
| import pytest | |||
There was a problem hiding this comment.
@mattip do these need to run as apptests in pypy?
| @@ -1,4 +1,5 @@ | |||
| from .support import HPyTest, SUPPORTS_SYS_EXECUTABLE, trampoline | |||
| import pytest | |||
There was a problem hiding this comment.
@mattip same question as for test_cpy_compat, do these need to run as apptests in pypy? If so I will pull the skip into the body of the methods like in test_object.py etc
Thanks, tests are passing now, just need someone to check if this'll work for PyPy apptests. |
|
All the |
|
It might be nice to make a release of HPy since HEAD includes the changes needed for Cython. |
With these changes we can build the HPy C extension on GraalPy and run the tests.