fix: derive MAX_PRECISION from the engine, not wrapper bindings#43
Open
hozblok wants to merge 1 commit into
Open
fix: derive MAX_PRECISION from the engine, not wrapper bindings#43hozblok wants to merge 1 commit into
hozblok wants to merge 1 commit into
Conversation
backend.py computed MAX_PRECISION by scanning the bound mp_real_<P> wrapper classes, so a .pyd with a sparse wrapper ladder (e.g. only mp_real_24) shrank the Solver bound to 24 — even though the Formula engine evaluates at any AllowedPrecisions value regardless of wrapper coverage. Expose csconstants::max_precision as _formula.MAX_PRECISION and read it directly. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
hozblok
force-pushed
the
fix/max-precision-not-tied-to-wrapper-bindings
branch
from
7479af0 to
20e5a02
Compare
hozblok
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
backend.pycomputedMAX_PRECISIONby scanning the boundmp_real_<P>wrapperclasses, so a .pyd with a sparse wrapper ladder (e.g. only
mp_real_24) shrank theSolver bound to 24:
The Formula engine itself evaluates at any
AllowedPrecisionsvalue regardless ofwrapper coverage — the two concepts are independent.
Fix
main.cpp: exposecsconstants::max_precisionas_formula.MAX_PRECISION.backend.py: read it directly instead of scanning wrappers.test_solver_precision_bounds.py: the constant comes fromthe engine attr, not from the wrapper scan.