feat: direct payment to organizer for non-refundable tickets#20
Merged
Conversation
Remove unused imports from deploy scripts, extract fee constants, inline facet deployment, add vm labels, and simplify mintTicketETH helper.
Split payment flow: refundable tickets escrow funds in the contract, non-refundable tickets send the ticket fee directly to the organizer. For ERC20 non-refundable payments, the fee is sent to the organizer and the hostIt fee is sent to the contract separately. Also updates _payWithToken to accept a destination address parameter.
Update assertions for non-refundable tickets where fees go directly to the organizer. Comment out refund and ticket balance withdrawal tests (no longer applicable for non-refundable tickets). Add receive() to test contract for ETH transfers.
…le flows Expand from 8 to 58 marketplace tests covering: - Non-refundable direct payment: organizer receives fee, contract holds only hostIt fee, no escrow (ETH, USDT, USDC) - Refundable escrow: funds escrowed, refund claims, withdraw after refund period, time-window revert cases (ETH, USDT, USDC) - Revert cases: insufficient balance/allowance, refund on non-refundable, withdraw zero balance, disabled fee type - Mixed scenarios: hostIt fee accumulation across ticket types - Add refundable ticket helpers to DeployedHostItTickets base
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
forge test) — 58 marketplace, 15 ticket, 13 factory, 3 check-inwithdrawHostItBalanceworks for all fee types after direct payment