Fix pending update on peer close#821
Merged
Merged
Conversation
marcus-pousette-hp
force-pushed
the
fix/peer-remove-pending-update-pr814
branch
from
221c0c0 to
2fb7d07
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The regression test covers the pending update waiter path. The
_maybeResolveIfAvailableRanges()call is included to preserve the completion checks thatupdateAll()used to run on peer removal. Current behaviour in main can introduce stalling behaviour and other un-intended side-effects when the completion checks are not invokedFound from the perf work at #814 while reviewing #815