[AhmethanKalenderoglu]

The tests in token_create_transaction_e2e_test.py now take the shared env fixture instead of creating IntegrationTestEnv() and closing it in try/finally. No change to what the tests check.

Fixes #2734

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Repository: hiero-ledger/hiero-sdk-python/.coderabbit.yaml
• Review profile: ASSERTIVE
• Plan: Advanced
• Run ID: e34d3b76-a62f-47fa-9420-0c8fddd374e0

📥 Commits

Reviewing files that changed from the base of the PR and between 8409f6b and c0d3cca.

📒 Files selected for processing: 1

• tests/integration/token_create_transaction_e2e_test.py

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

Token creation integration tests now use the env fixture instead of constructing and closing IntegrationTestEnv instances. The tests retain their existing token creation, signing, fee, auto-renew, expiration, and metadata assertions.

Changes

Token creation integration tests

Layer / File(s)	Summary
Use the shared environment fixture tests/integration/token_create_transaction_e2e_test.py	All tests in the file receive env from the fixture. The tests remove manual environment construction and cleanup while retaining their existing checks.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to c0d3c

Each token-creation test retains its own environment, which is closed after the test; no merge-readiness risk was identified.

Pre-merge checks: 3 · 1 · 1

Failed checks: 1 warning · 1 inconclusive

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 75.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 8 functions across 1 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Linked Issues check		Issue #2734 requires the shared env fixture, removal of direct IntegrationTestEnv construction and manual cleanup, unchanged test behavior, and verification with `uv run pytest tests/integration/t…	Provide the result of uv run pytest tests/integration/token_create_transaction_e2e_test.py and reviewable evidence for the complete changed file.

Passed checks: 3 passed

Check name	Status	Explanation
Title check		The title clearly describes the main change: using the shared env fixture in token creation integration tests.
Description check		The description accurately explains the fixture migration, removal of manual cleanup, and unchanged test behavior.
Out of Scope Changes check		The supplied summary identifies changes only in tests/integration/token_create_transaction_e2e_test.py. The changes replace per-test environment creation and cleanup with the shared env fixture. T…

Full details: Out of Scope Changes check

Explanation

The supplied summary identifies changes only in tests/integration/token_create_transaction_e2e_test.py. The changes replace per-test environment creation and cleanup with the shared env fixture. These changes directly implement issue #2734. The summary reports no unrelated behavior or assertion changes.

Full details: Linked Issues check

Explanation

Issue #2734 requires the shared env fixture, removal of direct IntegrationTestEnv construction and manual cleanup, unchanged test behavior, and verification with uv run pytest tests/integration/token_create_transaction_e2e_test.py. The supplied change summary supports the fixture and cleanup changes and states that the assertions remain. No test result is reported. The repository diff was unavailable, so the summary does not independently establish the complete implementation or test behavior.

Resolution

Provide the result of uv run pytest tests/integration/token_create_transaction_e2e_test.py and reviewable evidence for the complete changed file.

• Fix all pre-merge checks with AI

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

👋 Hi @AhmethanKalenderoglu! Great work completing a Good First Issue issue! 🎉

Thanks for your contribution! 🚀

Here are some issues you might want to explore next:

• Validate protobuf Timestamp range in TransactionId.from_string()

🌟 Stay connected:

• ⭐ Star this repository
• 👀 Watch for new issues
• 💬 Join us on Discord

Happy coding! 🚀
— Hiero Python SDK Team