ci: ensure goreleaser chart publish script runs only once#1041
Merged
Conversation
All artifacts must have a non empty ID, otherwise the `ids: [""]` filter will
include artifacts with an empty ID (strings in go are initialized to
"").
Add an ID to all artifacts to prevent running in the problem described
abovei and filter all IDs using a unused ID ("none") in the helm chart
publisher.
In addition, do skip publishing the helm chart if the chart file already
exists in the chart repository.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1041 +/- ##
=======================================
Coverage 67.52% 67.52%
=======================================
Files 23 23
Lines 3249 3249
=======================================
Hits 2194 2194
Misses 885 885
Partials 170 170
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lukasmetzner
approved these changes
Oct 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All artifacts must have a non empty ID, otherwise the
ids: [""]filter will include artifacts with an empty ID (strings in go are initialized to "").Add an ID to all artifacts to prevent running in the problem described abovei and filter all IDs using a unused ID ("none") in the helm chart publisher.
In addition, do skip publishing the helm chart if the chart file already exists in the chart repository.