Repository navigation
Combine and expand the editable and compiled test fixtures - #2155
Merged
Merged
Conversation
Merges the compiled VCS dependency tests into the editable tests, so that each package manager needs one app deploy instead of two, which speeds up the integration tests. The fixtures are renamed and restructured to match the CNB's `*_editable_git_compiled` fixtures: each now installs the root project in editable mode (using the package manager's default build backend and layout where it has one), plus a compiled VCS dependency (`extension.dist`) instead of a pure Python one. The pip fixture is the most comprehensive, since pip has no build backend of its own, so users end up picking from the variety of alternatives. It also covers a flat layout package that only has a `setup.py`, and hatchling in its default and `dev-mode-exact` modes. The latter isn't supported yet, since `bin/compile` doesn't rewrite the paths in its hook module, so the fixture, spec and `bin/compile` have `TODO`s for it to be fixed in a later PR. GUS-W-24373194.
edmorley
force-pushed
the
edmorley/simplify-editable-test-fixtures
branch
from
October 9, 2026 13:03
cad5ccb to
63c89f0
Compare
edmorley
marked this pull request as ready for review
October 9, 2026 13:06
edmorley
enabled auto-merge (squash)
October 9, 2026 13:06
Malax
approved these changes
Oct 9, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merges the compiled VCS dependency tests into the editable tests, so that each package manager needs one app deploy instead of two, which speeds up the integration tests. The fixtures are renamed and restructured to match the CNB's
*_editable_git_compiledfixtures: each now installs the root project in editable mode (using the package manager's default build backend and layout where it has one), plus a compiled VCS dependency (extension.dist) instead of a pure Python one.The pip fixture is the most comprehensive, since pip has no build backend of its own, so users end up picking from the variety of alternatives. It also covers a flat layout package that only has a
setup.py, and hatchling in its default anddev-mode-exactmodes. The latter isn't supported yet, sincebin/compiledoesn't rewrite the paths in its hook module, so the fixture, spec andbin/compilehaveTODOs for it to be fixed in a later PR.GUS-W-24373194.