fix: ensures dbname is always the last arg provided to pg_dump

[tlowrimore-heroku]

Summary

Addresses an issue originally reported in April of 2022, where the arguments being provided to pg_dump were not in the correct order (database name should be the last argument). This was not a problem on MacOS and Linux, but it resulted in an error, when run on Windows.

The originally proposed solution was to simple prepend the --exclude-table-data flag to the flags array. Our solution takes a different approach. Rather than expanding the connection arguments into the flags array, and only pushing additional flags onto the head of the array, the connection arguments are concatenated with the flags just before spawning the child command, within which pg_dump is executed. This allows for flags to be either prepended or appended to the flags array. By concatenating the connection args onto the flags array, we can guarantee connection args are always at the end of the args sent to pg_dump. This approach also ensures the flags array only contains flags.

Type of Change

Breaking Changes (major semver update)

• Add a ! after your change type to denote a change that breaks current behavior

Feature Additions (minor semver update)

• feat: Introduces a new feature to the codebase

Patch Updates (patch semver update)

• fix: Bug fix
• deps: Dependency upgrade
• revert: Revert a previous commit
• chore: Change that does not affect production code
• refactor: Refactoring existing code without changing behavior
• test: Add/update/remove tests

Testing

• CI should pass for all operating systems
• invoke pg:push and pg:pull on Windows, using the --exclude-table-data flag.

Screenshots

Tested on Windows

1. Verified the records in the remote (Heroku) database

2. Ran heroku pg:pull in Windows

3. Verified the database was restored, excluding the records in ideas table

Related Issues

GitHub issue: #1986
GUS work item: W-16153699

[jdodson]

Solid fix.

Approved.