optionally revoke token at the end of workflow run - #501
Open
kevinschoonover wants to merge 8 commits into
Open
Conversation
kevinschoonover
marked this pull request as ready for review
November 5, 2023 21:19
taylor1791
added a commit
to taylor1791/vault-action
that referenced
this pull request
Feb 3, 2024
v1v
reviewed
Dec 19, 2024
Comment on lines
+269
to
+273
| if (err instanceof got.HTTPError) { | ||
| throw Error(`failed to revoke vault token. code: ${err.code}, message: ${err.message}, vaultResponse: ${JSON.stringify(err.response.body)}`) | ||
| } else { | ||
| throw err | ||
| } |
There was a problem hiding this comment.
I would like to know whether fail on revoke can also be switched off with some flag, something like ignoreFailureRevokeToken.
v1v
approved these changes
Dec 19, 2024
dakshlohar1
approved these changes
Apr 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
adds the 'revokeToken' input to tell the action to automatically revoke the generated token after the run is complete.
closes #427
Checklist
dist/index.js(This is only done for releases by vault-action maintainers)Community Note
reaction
to the original pull request comment to help the community and maintainers
prioritize this request
followers and do not help prioritize the request