refactor: drop ineffective omitempty - #356
Open
tenthirtyam wants to merge 1 commit into
Open
Conversation
`encoding/json` treats struct values as never empty, so `json:",omitempty"` on the embedded `OnlyExcept` field in `PostProcessor` and `Provisioner` has no effect. Removes the misleading tags; `OnlyExcept `already applies `omitempty` to its `Only` and `Except` slice fields, and JSON output is unchanged. Signed-off-by: Ryan Johnson <ryan@tenthirtyam.org>
tenthirtyam
force-pushed
the
refactor/drop-ineffective-omitempty
branch
from
August 12, 2026 18:09
26841c1 to
ba5477b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
encoding/jsontreats struct values as never empty, sojson:",omitempty"on the embeddedOnlyExceptfield inPostProcessorandProvisionerhas no effect.Removes the misleading tags;
OnlyExceptalready appliesomitemptyto itsOnlyandExceptslice fields, and JSON output is unchanged.Resolved Issues
encoding/jsontreats struct values as never empty, sojson:",omitempty"on the embeddedOnlyExceptfield inPostProcessorandProvisionerhas no effect.Rollback Plan
Revery commit.
Changes to Security Controls
None.