Repository navigation
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The new discard can block streaming body logging, and truncated-output assertions miss partial credential leaks.
2 open issues
What changed in this PR
Adds fuzz coverage for HTTP body logging’s ReadTruncatedBody helper.
Changes:
- Adds fuzz seeds and normalization, length, and masking assertions.
- Adds CRLF and trailing-data error regression tests.
- Discards buffered data before checking for reader errors after truncation.
| File | Description |
|---|---|
| logging/testdata/fuzz/FuzzReadTruncatedBody/be5745a00b72578c | Adds a persisted fuzz input. |
| logging/http.go | Changes error detection after truncation. |
| logging/http_test.go | Adds newline and reader-error regressions. |
| logging/http_fuzz_test.go | Adds fuzz testing and normalization helper. |
Review effort: Balanced
gdavison
removed this pull request from stack #1545
October 17, 2026 00:06
gdavison
changed the base branch from
main
to
td-read-truncated-body-err-handling
October 17, 2026 00:08
gdavison
force-pushed
the
td-fuzz-read-truncated-body
branch
from
October 17, 2026 00:15
349881e to
4af560a
Compare
gdavison
added this pull request to stack #1547
October 17, 2026 00:16
gdavison
marked this pull request as draft
October 18, 2026 19:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Community Note
Reference: #0000 <!--- Pull Requests should have an associated issue or may be closed --->
Rollback Plan
If a change needs to be reverted, we will publish an updated version of the library.
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
Description
Adds fuzz tests for
ReadTruncatedBodyStack created with GitHub Stacks CLI • Give Feedback 💬