Repository navigation
Conversation
The library (Home, the server screens, Settings, Toolbar Keys, the shortcut lists and editors, the server forms) painted a blue slate of its own in dark mode, while sheets get iOS's colours: the session switcher at full height turns iOS's opaque grey beside the slate. Light mode already used iOS's grouped colours, and the slate matched only the Ghostty Default terminal theme, not Mocha or Latte. Lists and forms now keep iOS's default grouped styling, the hand-drawn pieces (section headers, server icon tiles, dividers, the shortcut editor's sections) use the matching system colours, and Connected uses iOS's green in dark mode too. Light mode is meant to look the same. The session forms keep their clear rows over the sheet's glass. Seven unused terminal-chrome slate colours go too.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Deploying getremux with
|
| Latest commit: |
470d0db
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8da9b1a5.getremux.pages.dev |
| Branch Preview URL: | https://design-system-colours.getremux.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
In dark mode, the library screens now use iOS's own grouped colours instead of Remux's blue slate. These are Home, the server screens, Settings, Toolbar Keys, Shortcuts and the shortcut editors, and the server forms. Pages are black with
#1C1C1Erows, as in iOS Settings, and sheets get iOS's raised#1C1C1Epage with#2C2C2Erows. Connected uses iOS's green in dark mode too.Why
Sheets already get iOS's colours, so at full height the session switcher turned iOS's opaque grey next to the slate around it. Light mode already used iOS's grouped colours. The slate was dark-mode only and matched just one terminal theme: Ghostty Default (
#282C34), not Mocha (#1E1E2E) or Latte.How
RemuxAppPaletteand its list helpers, so lists and forms keep iOS's default grouped styling.secondaryLabel,tertiarySystemFill,separator, and the grouped backgrounds.usesGroupedSurfaces.Before / after
Dark mode, iPhone 17 Pro simulator, iOS 27.2, same servers and data. Before is main at 6fd51de, after is this branch at 470d0db.
IMAGES
Validation
regularMaterialbackground, which this PR doesn't change. Also not checked: Increase Contrast.