Skip to content

silences filter messages from rspec#1034

Draft
andr3i-f wants to merge 2 commits into
grosser:masterfrom
andr3i-f:silencing-filter-messages
Draft

silences filter messages from rspec#1034
andr3i-f wants to merge 2 commits into
grosser:masterfrom
andr3i-f:silencing-filter-messages

Conversation

@andr3i-f
Copy link
Copy Markdown
Contributor

@andr3i-f andr3i-f commented May 2, 2026

Thank you for your contribution!

Checklist

  • [ x ] Feature branch is up-to-date with master (if not - rebase it).
  • [ x ] Added tests.
  • [ x ] Added an entry to the Changelog if the new
    code introduces user-observable changes.
  • [ - ] Update Readme.md when cli options are changed

Somewhat addresses #1025

@andr3i-f
Copy link
Copy Markdown
Contributor Author

andr3i-f commented May 2, 2026

@grosser let me know your thoughts on this fix. I also tried looking a little bit into getting parallel_tests to print out the setup line prior to running the tests (which I think makes most sense), but I am not really sure how that could be done.

@andr3i-f andr3i-f changed the title silences filter messages in base logger silences filter messages from rspec May 2, 2026
@grosser
Copy link
Copy Markdown
Owner

grosser commented May 7, 2026

how about you set --silence-filter-announcements in .rspec_parallel ... would that not solve it already ?

@andr3i-f
Copy link
Copy Markdown
Contributor Author

andr3i-f commented May 8, 2026

❯ rspec ./spec/parallel_tests/rspec --silence-filter-announcements                             06:37:25 PM
invalid option: --silence-filter-announcements

Please use --help for a listing of valid options

--silence-filter-announcements is not an option in rspec.

@grosser
Copy link
Copy Markdown
Owner

grosser commented May 8, 2026

ah yes, I assumed all setting have that 😞

Comment thread CHANGELOG.md
Comment on lines 10 to +12

### Fixed
- silence filter messages from rspec in base logger
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Fixed
- silence filter messages from rspec in base logger
- silence filter messages from rspec in base logger to prevent them from being repeated for every process
### Fixed

Copy link
Copy Markdown
Owner

@grosser grosser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is alright I guess
kinda inconsistent with mintest and the like
and with the output also being duplicated
... so not great but at least it's simple

thoughts on keeping enabled for the first process even if it ends up being in the middle ?

@andr3i-f
Copy link
Copy Markdown
Contributor Author

I just realized that the original issue references a different gem (parallel_rspec) in the first issue created in rspec (rspec/rspec#278)

I do agree with you that this is an 'alright' solution. The best solution would be to have the filter/set up messages printed once before the tests are ran, but I am not sure how to do that here without too much complexity. personally I don't think this is an ideal fix if it prints the filter messages in a random location & is not consistent with other test runners.

@andr3i-f
Copy link
Copy Markdown
Contributor Author

I can spend a bit more time to look into finding a possible solution, but if I can't find anything too simple, I think this PR can be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants