silences filter messages from rspec#1034
Conversation
|
@grosser let me know your thoughts on this fix. I also tried looking a little bit into getting parallel_tests to print out the setup line prior to running the tests (which I think makes most sense), but I am not really sure how that could be done. |
|
how about you set |
❯ rspec ./spec/parallel_tests/rspec --silence-filter-announcements 06:37:25 PM
invalid option: --silence-filter-announcements
Please use --help for a listing of valid options
|
|
ah yes, I assumed all setting have that 😞 |
|
|
||
| ### Fixed | ||
| - silence filter messages from rspec in base logger |
There was a problem hiding this comment.
| ### Fixed | |
| - silence filter messages from rspec in base logger | |
| - silence filter messages from rspec in base logger to prevent them from being repeated for every process | |
| ### Fixed |
grosser
left a comment
There was a problem hiding this comment.
this is alright I guess
kinda inconsistent with mintest and the like
and with the output also being duplicated
... so not great but at least it's simple
thoughts on keeping enabled for the first process even if it ends up being in the middle ?
|
I just realized that the original issue references a different gem (parallel_rspec) in the first issue created in rspec (rspec/rspec#278) I do agree with you that this is an 'alright' solution. The best solution would be to have the filter/set up messages printed once before the tests are ran, but I am not sure how to do that here without too much complexity. personally I don't think this is an ideal fix if it prints the filter messages in a random location & is not consistent with other test runners. |
|
I can spend a bit more time to look into finding a possible solution, but if I can't find anything too simple, I think this PR can be closed |
Thank you for your contribution!
Checklist
master(if not - rebase it).code introduces user-observable changes.
Somewhat addresses #1025