feat(gks)!: add constraints and members to categorical variants#233
Draft
korikuzma wants to merge 12 commits into
Draft
feat(gks)!: add constraints and members to categorical variants#233korikuzma wants to merge 12 commits into
korikuzma wants to merge 12 commits into
Conversation
korikuzma
commented
Jun 5, 2026
Collaborator
Author
There was a problem hiding this comment.
Would love to eventually split out the current test_exports.py module
korikuzma
commented
Jun 11, 2026
| molecular_profile, expressions, variation_normalizer | ||
| ) | ||
|
|
||
| super().__init__( |
Collaborator
Author
There was a problem hiding this comment.
Open question: Should we be returning the recipes, such as PSC, CategoricalCNV, etc? Or have downstream users validate these constraints?
close #209 * Migrate work from metakb (@jsstevenson helped write this code) * Adds Variation Normalizer REST Data Proxy to retrieve normalized VRS variations (only supports Allele and CopyNumberChange) * Require that Molecular Profiles represented as Categorical Variants use constraints Co-authored-by: James Stevenson <james.stevenson@nationwidechildrens.org>
Collaborator
Author
|
From @ahwagner
and Change subjectVariant.extensions.expressions and revert to how CIViC represents it. "HGVS Descriptions": list[str] |
Collaborator
Author
|
Forgot about ga4gh/va-spec#404 (comment) |
korikuzma
changed the title
Collaborator
Author
|
tag daniel on what output looks like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #209