graph: Round BigInt cache weight up to full bytes#6493
Open
cuiweixie wants to merge 1 commit intographprotocol:masterfrom
Open
graph: Round BigInt cache weight up to full bytes#6493cuiweixie wants to merge 1 commit intographprotocol:masterfrom
cuiweixie wants to merge 1 commit intographprotocol:masterfrom
Conversation
Use ceiling division when converting bit length to bytes so values whose bit width is not a multiple of eight are not undercounted for cache accounting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
CacheWeight::indirect_weightforBigIntto use ceiling division when converting the bit length to a byte count ((bits + 7) / 8). Integer division by eight previously undercounted values whose bit width is not a multiple of eight.Commit convention
Matches project style:
{crate-name}: {description}(see CLAUDE.md and recent history onmaster).Testing
just lint/just check --release(recommended before merge; not run in this environment due to crates.io SSL issues)