Fix 32-bit regressions in ndarray encode/decode and stochastic rounding tests#60
Merged
awf merged 3 commits intographcore-research:mainfrom Apr 17, 2026
Merged
Fix 32-bit regressions in ndarray encode/decode and stochastic rounding tests#60awf merged 3 commits intographcore-research:mainfrom
awf merged 3 commits intographcore-research:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title
Fix 32-bit regressions in ndarray encode/decode and stochastic rounding tests
Description
Summary
This PR resolves issue #57 by removing temporary 32-bit xfails and fixing the underlying dtype/bit-packing issues that caused i386 failures.
Changes
ldexpexponent/input dtypes.int64so2**32bounds work on 32-bit Python.srnumbits=32) after dtype-safe generation.pytesttesttarget is only used when no args are suppliedsh ...invocation remains robustValidation
sh etc/test-linux-386.sh run -vv test/test_encode.py::test_encode[binary32]✅sh etc/test-linux-386.sh run✅ (913 passed, 3 skipped)872 passed)Context
Closes #57.