Skip to content

adds dsconfig schema - #693

Open
jcolladokuri wants to merge 11 commits into
mainfrom
jck/schema
Open

adds dsconfig schema#693
jcolladokuri wants to merge 11 commits into
mainfrom
jck/schema

Conversation

@jcolladokuri

@jcolladokuri jcolladokuri commented Jun 26, 2026

Copy link
Copy Markdown

Summary

This PR adds the datasource configuration schema for the datasource. With the schema consumers such as llm agents, provisioning agents, etc will understand the shape and meta data about the datasource configuration.

Read more at

@cla-assistant

cla-assistant Bot commented Jun 26, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@jcolladokuri
jcolladokuri requested a review from Copilot June 26, 2026 23:04
@cla-assistant

cla-assistant Bot commented Jun 26, 2026

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds dsconfig-based configuration schema support for the Amazon Timestream datasource so downstream tools (including agents) can introspect required configuration fields via a uniform schema and generated artifacts.

Changes:

  • Added pkg/schema/dsconfig.json as the dsconfig single source of truth for datasource configuration fields and groups.
  • Added generated schema artifacts (schema.gen.json, settings.gen.json, settings.examples.gen.json) and a conformance test (dsconfig_test.go) to validate drift.
  • Updated Go dependencies (including grafana-plugin-sdk-go) to support dsconfig/schema tooling.

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
pkg/schema/dsconfig.json New dsconfig schema defining settings fields, secure fields, and UI groups.
pkg/schema/dsconfig_test.go Adds dsconfig conformance + artifact generation test harness.
pkg/schema/schema.gen.json Generated full plugin schema artifact derived from dsconfig.json.
pkg/schema/settings.gen.json Generated settings-only schema artifact derived from dsconfig.json.
pkg/schema/settings.examples.gen.json Generated settings examples artifact.
go.mod Bumps Go/tooling deps needed for schema generation/conformance.
go.sum Updates checksums for dependency changes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread pkg/schema/dsconfig.json Outdated
@github-actions

Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 2 weeks if no further activity occurs. Please feel free to give a status update or ping for review. Thank you for your contributions!

@github-actions github-actions Bot added the stale label Jul 27, 2026
@jcolladokuri
jcolladokuri marked this pull request as ready for review July 30, 2026 03:10
@jcolladokuri
jcolladokuri requested a review from a team as a code owner July 30, 2026 03:10
@github-actions github-actions Bot removed the stale label Jul 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants