Skip to content

fix(plugin-e2e): don't assume panel options group is expanded by default - #2855

Merged
sunker merged 1 commit into
mainfrom
sunker/panel-options-group-expand-default
Aug 27, 2026
Merged

fix(plugin-e2e): don't assume panel options group is expanded by default#2855
sunker merged 1 commit into
mainfrom
sunker/panel-options-group-expand-default

Conversation

@sunker

@sunker sunker commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

The nightly E2E workflow failed against Grafana's nightly image: grafana/grafana@5f1776a28c changed panel options categories to collapse by default when they have zero items, breaking panelEdit.spec.ts's "Data links" group tests. Fixes the tests to force expand/collapse state instead of assuming a default, and fixes getDataLinksOptions() to resolve the label per Grafana version.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Broken nightly run: https://github.com/grafana/plugin-tools/actions/runs/33056766956

@sunker sunker added the preview Opts the PR into pkg.pr.new preview publishing label Aug 27, 2026
@pkg-pr-new

pkg-pr-new Bot commented Aug 27, 2026

Copy link
Copy Markdown

Open in StackBlitz

@grafana/create-plugin

npm i https://pkg.pr.new/grafana/plugin-tools/@grafana/create-plugin@b7a0e93 -D

@grafana/eslint-config

npm i https://pkg.pr.new/grafana/plugin-tools/@grafana/eslint-config@b7a0e93 -D

@grafana/eslint-plugin-plugins

npm i https://pkg.pr.new/grafana/plugin-tools/@grafana/eslint-plugin-plugins@b7a0e93 -D

@grafana/plugin-docs-cli

npm i https://pkg.pr.new/grafana/plugin-tools/@grafana/plugin-docs-cli@b7a0e93 -D

@grafana/plugin-docs-parser

npm i https://pkg.pr.new/grafana/plugin-tools/@grafana/plugin-docs-parser@b7a0e93 -D

@grafana/plugin-e2e

npm i https://pkg.pr.new/grafana/plugin-tools/@grafana/plugin-e2e@b7a0e93 -D

@grafana/plugin-meta-extractor

npm i https://pkg.pr.new/grafana/plugin-tools/@grafana/plugin-meta-extractor@b7a0e93 -D

@grafana/plugin-types-bundler

npm i https://pkg.pr.new/grafana/plugin-tools/@grafana/plugin-types-bundler@b7a0e93 -D

@grafana/react-detect

npm i https://pkg.pr.new/grafana/plugin-tools/@grafana/react-detect@b7a0e93 -D

@grafana/sign-plugin

npm i https://pkg.pr.new/grafana/plugin-tools/@grafana/sign-plugin@b7a0e93 -D

@grafana/tsconfig

npm i https://pkg.pr.new/grafana/plugin-tools/@grafana/tsconfig@b7a0e93 -D

commit: b7a0e93

@sunker
sunker marked this pull request as ready for review August 27, 2026 11:34
@sunker
sunker requested a review from a team as a code owner August 27, 2026 11:34
@sunker
sunker requested review from Ukochka, academo and xnyo and removed request for a team August 27, 2026 11:34

@mckn mckn left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-project-automation github-project-automation Bot moved this from 📬 Triage to 🔬 In review in Grafana Catalog Team Aug 27, 2026
@sunker
sunker merged commit 490b663 into main Aug 27, 2026
41 checks passed
@sunker
sunker deleted the sunker/panel-options-group-expand-default branch August 27, 2026 12:22
@github-project-automation github-project-automation Bot moved this from 🔬 In review to 🚀 Shipped in Grafana Catalog Team Aug 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

preview Opts the PR into pkg.pr.new preview publishing

Projects

Status: 🚀 Shipped

Development

Successfully merging this pull request may close these issues.

2 participants