feat(playwright): add plugin-directory input to e2e-version - #696
Draft
sunker wants to merge 5 commits into
Draft
Conversation
Wires the plugin-path input through ci.yml, cd.yml, playwright.yml and playwright-docker.yml for testing against grafana/plugin-actions#212 (feat/plugin-path-input, pinned to c81db32). This is a test branch - not for merging until plugin-actions PR #212 is released.
grafana-plugins-platform-bot
Bot
moved this from 📬 Triage
to 🔬 In review
in Grafana Catalog Team
sunker
changed the title
Contributor
Author
|
@joeblubaugh can you please confirm this PR solves the problem in your plugin? |
Contributor
|
@sunker obsolete? |
Contributor
Author
|
pinging @joeblubaugh once again before closing this draft |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test branch for grafana/plugin-actions#212, which adds a
plugin-directoryinput to thee2e-versionaction.Do not merge — this pins to a commit SHA on an unreleased branch. Once plugin-actions PR #212 is merged and tagged, this should be redone against the release tag.
What this adds
Passes the existing
plugin-directoryinput through to thee2e-versionaction in bothplaywright.ymlandplaywright-docker.yml, so the action can findsrc/plugin.jsonin the correct location for plugins in subdirectories (e.g. monorepos).No new inputs are needed in
ci.ymlorcd.yml— the existingplugin-directoryinput already flows through.Why this is better than reading plugin.json in the workflow
The
e2e-versionaction already knows how to readgrafanaDependencyfromplugin.json— it just needs to know where to look. Keeping that logic in the action avoids duplicating it in the workflow and means any other consumer ofe2e-versiongets the fix automatically.Testing
Point a plugin's CI at this branch: