fix: Support Lineage Tracking for Top-Level and Nested Enums#58
Open
luthfifahlevi wants to merge 1 commit into
Open
fix: Support Lineage Tracking for Top-Level and Nested Enums#58luthfifahlevi wants to merge 1 commit into
luthfifahlevi wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes a bug in the Stencil Lineage API where requesting lineage for an Enum FQN (e.g.,
gotocompany.events.DataTypes.Enum) incorrectly returned an empty result (downstream_count: 0).The root cause was a blind spot in the AST root lookup engine. The
findRootFQNsandcollectFQNsfunctions were exclusively iterating over Message types (fd.GetMessageType()), meaning Enum definitions were never registered as valid vertices in the lineage graph. Consequently, the traversal skipped them entirely.Key Changes
findRootFQNsto iterate over and indexfd.GetEnumType(), ensuring file-level enums are registered in the graph lookup map.collectFQNsfunction to iterate over and indexmsg.GetEnumType(), allowing enums nested inside parent messages to be accurately targeted.buildEnumDescriptorSetBytes) and subtest to verify that tracing downstream lineage starting directly from an Enum successfully identifies the parent messages and schemas that consume it.Impact
This fix unlocks accurate downstream impact analysis for Enum modifications.