Skip to content

chore(storage): fix order dependency in get_object_contexts test #34844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aandreassa wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −5
Open

chore(storage): fix order dependency in get_object_contexts test #34844

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions google-cloud-storage/Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ GEM
googleapis-common-protos-types (~> 1.15)
googleauth (~> 1.12)
grpc (~> 1.66)
google-apis-core (1.2.4)
google-apis-core (1.2.5)
addressable (~> 2.9)
faraday (~> 2.13)
faraday-follow_redirects (~> 0.3)
Expand Down Expand Up @@ -332,7 +332,7 @@ CHECKSUMS
faraday-net_http (3.4.4) sha256=0e78af151747ed1b00f33e25973b4bc220d7f16c00c39676817c8b12331eb588
faraday-retry (2.4.0) sha256=7b79c48fb7e56526faf247b12d94a680071ff40c9fda7cf1ec1549439ad11ebe
gapic-common (1.3.0) sha256=4e5d9be1effb7366e2cda13c0f44922285d5613ac8de8b9b18c2c835fe4faa91
google-apis-core (1.2.4) sha256=da9d12dbc7a3fbf3a68fc461e23e6f23245e57ab3b47eb71137d4dcf61a686b3
google-apis-core (1.2.5) sha256=e21562b5627a0fc6a0c3165e429c3afed0f6a628eaa514e83f7204dda1adff69
google-apis-iamcredentials_v1 (0.28.0) sha256=0a92ffe6cc39c569554af2a77a25dfc61519ed8bbb64ab04cffdd352dc5ef106
google-apis-storage_v1 (0.64.0) sha256=75b11afa2edcee859b84c7a6972ee4456314eeef5f762827fd6cf5c5ffaf93f2
google-cloud-core (1.9.0)
Expand Down
9 changes: 6 additions & 3 deletions google-cloud-storage/samples/acceptance/files_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@
end

after do
bucket.requester_pays = false
storage_client.bucket(bucket.name, user_project: storage_client.project).requester_pays = false
bucket.files.each(&:delete)
end

Expand Down Expand Up @@ -337,10 +337,13 @@ def mock_cipher.random_key
set_object_contexts bucket_name: bucket.name, file_name: remote_file_name, custom_context_key: custom_context_key2, custom_context_value: custom_context_value2
end
it "fetches all object contexts" do

assert_output "Custom Contexts for #{remote_file_name} are:\nKey: #{custom_context_key1}, Value: #{custom_context_value1}\nKey: #{custom_context_key2}, Value: #{custom_context_value2}\n" do
out, _err = capture_io do
get_object_contexts bucket_name: bucket.name, file_name: remote_file_name
end

assert_includes out, "Custom Contexts for #{remote_file_name} are:\n"
assert_includes out, "Key: #{custom_context_key1}, Value: #{custom_context_value1}\n"
assert_includes out, "Key: #{custom_context_key2}, Value: #{custom_context_value2}\n"
end
end

Expand Down
Loading