Skip to content

fix: require Python 3.10+#17245

Open
parthea wants to merge 16 commits into
mainfrom
enable-bigtable-generation-release
Open

fix: require Python 3.10+#17245
parthea wants to merge 16 commits into
mainfrom
enable-bigtable-generation-release

Conversation

@parthea
Copy link
Copy Markdown
Contributor

@parthea parthea commented May 25, 2026

chore: enable generation / release for bigtable

Fixes b/510022189, b/507893758, b/507889482, b/503326310

@parthea parthea self-assigned this May 25, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the google-cloud-bigtable library, bumping the minimum supported Python version to 3.10 and updating core dependencies. It introduces internal session-related types, adds an Edition field to the Instance type, and enhances AutomatedBackupPolicy with location-based settings. The PR also includes significant cleanup of repository metadata, fixes to asynchronous sample code, and updates to the documentation and copyright headers. I have no feedback to provide.

@parthea parthea marked this pull request as ready for review May 26, 2026 14:21
@parthea parthea requested review from a team as code owners May 26, 2026 14:21
@parthea parthea assigned chalmerlowe and unassigned parthea May 26, 2026
@parthea parthea changed the title chore: enable google-cloud-bigtable generation/release fix: require Python 3.10+ May 26, 2026
@chalmerlowe
Copy link
Copy Markdown
Contributor

This file has a lingering reference to 3.8 that is unnecessary:

Other than that, this looks very clean of all references to 3.7, 3.8, 3.9. Lingering references appear to be standard boilerplate that should be there.

Copy link
Copy Markdown
Contributor

@chalmerlowe chalmerlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to request that one last unnecessary reference to version 3.8 be removed.

Other than that, approved.

@parthea
Copy link
Copy Markdown
Contributor Author

parthea commented May 26, 2026

New failures

FAILED tests/unit/data/_async/test_client.py::TestBigtableDataClientAsync::test__start_background_channel_refresh_sync - RuntimeError: There is no current event loop in thread 'MainThread'.
FAILED tests/unit/data/_async/test_client.py::TestBigtableDataClientAsync::test_client_ctor_sync - Failed: DID NOT WARN. No warnings of type (<class 'RuntimeWarning'>,) were emitted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants