chore: release test-release-please#8311
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates multiple packages across the repository, including version increments and dependency management adjustments. The changes involve pinning the sinon dependency to 21.0.3 and adding overrides for @sinonjs/fake-timers to ensure consistency across the monorepo. The reviewer identified that these dependency management patterns were missing in the newly added google-cloud-appoptimize and google-cloud-databasecenter packages and provided specific code suggestions to include them.
| "long": "^5.3.1", | ||
| "mocha": "^11.1.0", | ||
| "pack-n-play": "^3.0.0", | ||
| "sinon": "^21.0.0", |
| } | ||
| } |
There was a problem hiding this comment.
This package is missing the overrides block for @sinonjs/fake-timers that is being added to other packages in this pull request to ensure dependency consistency across the monorepo.
| } | |
| } | |
| }, | |
| "overrides": { | |
| "@sinonjs/fake-timers": "15.2.1" | |
| }, | |
| "pnpm": { | |
| "overrides": { | |
| "@sinonjs/fake-timers": "15.2.1" | |
| } | |
| } | |
| } |
| "long": "^5.3.1", | ||
| "mocha": "^11.1.0", | ||
| "pack-n-play": "^3.0.0", | ||
| "sinon": "^21.0.0", |
| } | ||
| } |
There was a problem hiding this comment.
The overrides block for @sinonjs/fake-timers is missing in this package. It should be added to match the dependency management strategy applied to other packages in this PR.
| } | |
| } | |
| }, | |
| "overrides": { | |
| "@sinonjs/fake-timers": "15.2.1" | |
| }, | |
| "pnpm": { | |
| "overrides": { | |
| "@sinonjs/fake-timers": "15.2.1" | |
| } | |
| } | |
| } |
This release is too large to preview in the pull request body. View the full release notes here: https://github.com/googleapis/google-cloud-node/blob/release-please--branches--test-release-please--release-notes/release-notes.md