Skip to content

chore: release test-release-please#8311

Closed
jskeet wants to merge 7 commits into
test-release-pleasefrom
release-please--branches--test-release-please
Closed

chore: release test-release-please#8311
jskeet wants to merge 7 commits into
test-release-pleasefrom
release-please--branches--test-release-please

Conversation

@jskeet
Copy link
Copy Markdown
Contributor

@jskeet jskeet commented May 19, 2026

This release is too large to preview in the pull request body. View the full release notes here: https://github.com/googleapis/google-cloud-node/blob/release-please--branches--test-release-please--release-notes/release-notes.md

@jskeet jskeet requested a review from a team as a code owner May 19, 2026 08:56
@jskeet jskeet closed this May 19, 2026
@jskeet jskeet deleted the release-please--branches--test-release-please branch May 19, 2026 08:57
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates multiple packages across the repository, including version increments and dependency management adjustments. The changes involve pinning the sinon dependency to 21.0.3 and adding overrides for @sinonjs/fake-timers to ensure consistency across the monorepo. The reviewer identified that these dependency management patterns were missing in the newly added google-cloud-appoptimize and google-cloud-databasecenter packages and provided specific code suggestions to include them.

"long": "^5.3.1",
"mocha": "^11.1.0",
"pack-n-play": "^3.0.0",
"sinon": "^21.0.0",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For consistency with the rest of the repository in this release, the sinon version should be pinned to 21.0.3 instead of using a caret range.

Suggested change
"sinon": "^21.0.0",
"sinon": "21.0.3",

Comment on lines +69 to +70
}
}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This package is missing the overrides block for @sinonjs/fake-timers that is being added to other packages in this pull request to ensure dependency consistency across the monorepo.

Suggested change
}
}
},
"overrides": {
"@sinonjs/fake-timers": "15.2.1"
},
"pnpm": {
"overrides": {
"@sinonjs/fake-timers": "15.2.1"
}
}
}

"long": "^5.3.1",
"mocha": "^11.1.0",
"pack-n-play": "^3.0.0",
"sinon": "^21.0.0",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The sinon version should be pinned to 21.0.3 to maintain consistency with other packages updated in this release.

Suggested change
"sinon": "^21.0.0",
"sinon": "21.0.3",

Comment on lines +69 to +70
}
}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The overrides block for @sinonjs/fake-timers is missing in this package. It should be added to match the dependency management strategy applied to other packages in this PR.

Suggested change
}
}
},
"overrides": {
"@sinonjs/fake-timers": "15.2.1"
},
"pnpm": {
"overrides": {
"@sinonjs/fake-timers": "15.2.1"
}
}
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant