Skip to content

[byteorder] Add optional defmt::Format impls - #3928

Open
korken89 wants to merge 1 commit into
google:mainfrom
korken89:defmt
Open

korken89 wants to merge 1 commit into
google:mainfrom
korken89:defmt

Conversation

@korken89

Copy link
Copy Markdown

Add a defmt feature which implements defmt::Format for the byteorder types by formatting the native value.

Based on issue #3914

Add a `defmt` feature which implements `defmt::Format` for the
byteorder types by formatting the native value.
@google-cla

google-cla Bot commented Nov 18, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-18T07:34:09.386526Z 9712cc9 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9712cc9eb3

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread zerocopy/Cargo.toml
]

[dependencies]
defmt = { version = "1", optional = true }

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Vendor and lock the new defmt dependency

BLOCKING: The checked-in zerocopy/Cargo.lock still omits defmt, and a repo-wide search of the reviewed tree finds no zerocopy/vendor/defmt*, even though .cargo/config.toml replaces crates.io with that vendor directory. In the inspected codegen workflow, .github/workflows/ci.yml:679-694 runs ./cargo.sh ... --locked --all-features; cargo check --help defines --locked as “Assert that Cargo.lock will remain unchanged,” so it cannot repair this stale lock, and even non-locked wrapper commands cannot resolve a crate absent from the configured source. Regenerate the lockfile and vendor this dependency before merging.

AGENTS.md reference: zerocopy/AGENTS.md:L15-L16

Useful? React with 👍 / 👎.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant