Repository navigation
Conversation
Add a `defmt` feature which implements `defmt::Format` for the byteorder types by formatting the native value.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9712cc9eb3
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| ] | ||
|
|
||
| [dependencies] | ||
| defmt = { version = "1", optional = true } |
There was a problem hiding this comment.
Vendor and lock the new defmt dependency
BLOCKING: The checked-in zerocopy/Cargo.lock still omits defmt, and a repo-wide search of the reviewed tree finds no zerocopy/vendor/defmt*, even though .cargo/config.toml replaces crates.io with that vendor directory. In the inspected codegen workflow, .github/workflows/ci.yml:679-694 runs ./cargo.sh ... --locked --all-features; cargo check --help defines --locked as “Assert that Cargo.lock will remain unchanged,” so it cannot repair this stale lock, and even non-locked wrapper commands cannot resolve a crate absent from the configured source. Regenerate the lockfile and vendor this dependency before merging.
AGENTS.md reference: zerocopy/AGENTS.md:L15-L16
Useful? React with 👍 / 👎.
Add a
defmtfeature which implementsdefmt::Formatfor the byteorder types by formatting the native value.Based on issue #3914