feat(llm): update SecGemini provider to parse attached JSONL findings - #3907
Open
samomi-oss wants to merge 4 commits into
Open
samomi-oss wants to merge 4 commits into
samomi-oss wants to merge 4 commits into
Conversation
jkppr
self-requested a review
September 9, 2026 12:41
Collaborator
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the _run_async_stream method in secgemini_log_analyzer_agent.py to parse findings from the LLM response by walking backward from the end of the response, while keeping a fallback for the legacy format. Feedback suggests wrapping the translation of individual findings in their own try-except blocks to prevent a single malformed finding from aborting the entire process, and adding safety checks for cases where record_ids might be None or not a list.
…ntries Addresses review feedback on google#3907: - Skip non-dict findings instead of aborting the whole batch. - Guard against null/non-list record_ids. - Wrap each finding translation in its own try/except so a single malformed finding no longer drops all subsequent valid findings.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates
SecGeminiLogAnalyzerin Timesketch to parse JSON Lines (.jsonl) investigation findings deliverables attached toMESSAGE_TYPE_RESPONSE.Changes
#), stripping code fences (```), and parsing each JSONL line into findings.report_summary.## Investigation Findingsblocks.blackformatting andpylint --rcfile=.pylintrc.