Mark the CompressionOptions(int) constructor explicit - #263
Open
rvandermeulen wants to merge 1 commit into
Open
rvandermeulen wants to merge 1 commit into
rvandermeulen wants to merge 1 commit into
Conversation
A single-argument constructor without explicit allows an int to convert implicitly to CompressionOptions, so an accidental Compress(reader, writer, 2) compiles without complaint. Nothing in the library relies on the conversion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A single-argument constructor without explicit lets an int convert implicitly to CompressionOptions, so an accidental Compress(reader, writer, 2) compiles silently. Nothing in the library relies on the conversion, and the style guide asks for explicit on single-argument constructors. Firefox has carried this as a local patch since 1.2.0.