fix(bakery): remove income column from demographics CSV and fix dataset description#53
Merged
Merged
Conversation
…sv and fix dataset description
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a critical data alignment (column shift) bug and resolves a privacy concern regarding data in the
launchmybakeryBigQuery setup.1. Strip Income Column and Fix Demographics Shift
The Issue:
Since
median_household_incomeremained in the sourcedata/demographics.csvfile,bq load(which maps columns positionally for CSV) actually imported the income data under the column nametotal_population.This caused:
median_age, making residents appear33626years old, and completely discardingfoot_traffic_index).The Fix:
Since the income column is not queried or utilized anywhere in the agent or tool code, I have completely removed the
median_household_incomecolumn (and its header) from the sourcedata/demographics.csvfile.2. Define Dataset Description Variable
The Issue:
The dataset creation command was using
--description "$DATASET_DESCRIPTION", but the variable$DATASET_DESCRIPTIONwas never initialized, resulting in an empty dataset description.The Fix:
Defined
DATASET_DESCRIPTION="Dataset for MCP Bakery Demo"at the top ofsetup_bigquery.sh.