Repository navigation
kb: fix incorrect group and description metadata (avif, fortran, one, swf, tcl) - #1545
Merged
Merged
Conversation
shivamtiwari3
requested review from
ia0,
invernizzi and
reyammer
as code owners
October 14, 2026 09:41
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates metadata for several content types (avif, fortran, one, swf, and tcl) across assets/content_types.yaml, rust/ffi/src/content.rs, and rust/lib/src/content.rs. Specifically, it corrects group classifications (e.g., avif to "image", fortran to "code") and refines descriptions (e.g., "One Note" to "OneNote", "Small Web File" to "Small Web Format", and "Tickle" to "Tcl"). There are no review comments, and I have no feedback to provide.
Collaborator
|
Thanks for the PR. Since this is very similar to your last PR, do you have others coming touching the same files or this is it? |
Contributor
Author
|
Nope, that's all of them. Nothing else queued. These two PRs cover everything I spotted. Thanks! |
… swf, tcl) - avif: group video -> image (AVIF is an image format; mime image/avif, and heif is grouped as image). - fortran: group document -> code (it is a programming language; every other language source type is grouped as code). - one: description "One Note" -> "OneNote" (Microsoft product name). - swf: description "Small Web File" -> "Small Web Format" (SWF). - tcl: description "Tickle" -> "Tcl" (Tool Command Language). Regenerated with scripts/sync_kb.py and rust/gen.
reyammer
force-pushed
the
kb-fix-metadata-followup
branch
from
October 15, 2026 09:23
f462288 to
63b22b3
Compare
reyammer
approved these changes
Oct 15, 2026
reyammer
approved these changes
Oct 15, 2026
Collaborator
|
got it, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this PR is in scope: Always-welcome item — KB metadata fix for content types already in the knowledge base. A follow-up to #1543.
TL;DR
Five metadata corrections in
assets/content_types.yaml:avifgroupvideoimageimage/avif, "AV1 Image File Format");heifis alreadyimagefortrangroupdocumentcodecodeonedescriptionOne NoteOneNoteswfdescriptionSmall Web FileSmall Web FormattcldescriptionTickleTclGenerated files regenerated with
uv run scripts/sync_kb.pyandrust/gen(cargo run), updatingassets/content_types_kb.min.json,rust/lib/src/content.rs, andrust/ffi/src/content.rs.How I tested it
No sample files, versions, or models were touched.