Skip to content

kb: fix incorrect group and description metadata (avif, fortran, one, swf, tcl) - #1545

Merged
reyammer merged 1 commit into
google:mainfrom
shivamtiwari3:kb-fix-metadata-followup
Oct 15, 2026
Merged

reyammer merged 1 commit into
google:mainfrom
shivamtiwari3:kb-fix-metadata-followup

Conversation

@shivamtiwari3

Copy link
Copy Markdown
Contributor

Why this PR is in scope: Always-welcome item — KB metadata fix for content types already in the knowledge base. A follow-up to #1543.

TL;DR

Five metadata corrections in assets/content_types.yaml:

entry field wrong fixed why
avif group video image AVIF is an image format (image/avif, "AV1 Image File Format"); heif is already image
fortran group document code it is a programming language; every other language source type is code
one description One Note OneNote Microsoft product name
swf description Small Web File Small Web Format SWF = Small Web Format
tcl description Tickle Tcl Tool Command Language

Generated files regenerated with uv run scripts/sync_kb.py and rust/gen (cargo run), updating assets/content_types_kb.min.json, rust/lib/src/content.rs, and rust/ffi/src/content.rs.

How I tested it

uv run scripts/sync_kb.py            # regenerated the JSON KB
uv run scripts/sync_kb.py --check    # in sync
(cd rust/gen && cargo run)           # regenerated rust/lib and rust/ffi content.rs
(cd rust/lib && ./test.sh)           # cargo check/test/fmt/clippy pass (3 passed, 1 ignored)

No sample files, versions, or models were touched.

  • I have read and understood every line of this PR and can discuss it.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates metadata for several content types (avif, fortran, one, swf, and tcl) across assets/content_types.yaml, rust/ffi/src/content.rs, and rust/lib/src/content.rs. Specifically, it corrects group classifications (e.g., avif to "image", fortran to "code") and refines descriptions (e.g., "One Note" to "OneNote", "Small Web File" to "Small Web Format", and "Tickle" to "Tcl"). There are no review comments, and I have no feedback to provide.

@reyammer

Copy link
Copy Markdown
Collaborator

Thanks for the PR. Since this is very similar to your last PR, do you have others coming touching the same files or this is it?

@shivamtiwari3

shivamtiwari3 commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor Author

Nope, that's all of them. Nothing else queued. These two PRs cover everything I spotted. Thanks!

… swf, tcl)

- avif: group video -> image (AVIF is an image format; mime image/avif,
  and heif is grouped as image).
- fortran: group document -> code (it is a programming language; every
  other language source type is grouped as code).
- one: description "One Note" -> "OneNote" (Microsoft product name).
- swf: description "Small Web File" -> "Small Web Format" (SWF).
- tcl: description "Tickle" -> "Tcl" (Tool Command Language).

Regenerated with scripts/sync_kb.py and rust/gen.
@reyammer
reyammer force-pushed the kb-fix-metadata-followup branch from f462288 to 63b22b3 Compare October 15, 2026 09:23
@reyammer
reyammer removed the request for review from ia0 October 15, 2026 12:35
@reyammer
reyammer merged commit de55f89 into google:main Oct 15, 2026
30 checks passed
@reyammer

Copy link
Copy Markdown
Collaborator

got it, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants