Refactor: Improve map entry parsing in GeneratedMessage.mm#2698
Open
copybara-service[bot] wants to merge 1 commit intomasterfrom
Open
Refactor: Improve map entry parsing in GeneratedMessage.mm#2698copybara-service[bot] wants to merge 1 commit intomasterfrom
copybara-service[bot] wants to merge 1 commit intomasterfrom
Conversation
copybara-service
bot
force-pushed
the
test_895935026
branch
from
8841ac7 to
d6356c8
Compare
This change adds validation for map key types and ensures that default values are used for missing key or value fields when parsing map entries from a stream. Error handling is also improved by checking the return value of `ReadMapEntryField`. By adding a couple of judicious autoreleases, it also protects us from memory leaks in case of bad maps. PiperOrigin-RevId: 895935026
copybara-service
bot
force-pushed
the
test_895935026
branch
from
d6356c8 to
b94cd10
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor: Improve map entry parsing in GeneratedMessage.mm
This change adds validation for map key types and ensures that default values are used for missing key or value fields when parsing map entries from a stream. Error handling is also improved by checking the return value of
ReadMapEntryField.By adding a couple of judicious autoreleases, it also protects us from memory leaks in case of bad maps.