fix(sessions): prevent VertexAiSessionService from dropping latest events under clock skew#1174
Open
merra3012 wants to merge 1 commit intogoogle:mainfrom
Open
fix(sessions): prevent VertexAiSessionService from dropping latest events under clock skew#1174merra3012 wants to merge 1 commit intogoogle:mainfrom
merra3012 wants to merge 1 commit intogoogle:mainfrom
Conversation
Stop filtering getSession events by session updateTime because updateTime is server-side and Event.timestamp is client-side, which can silently drop valid latest events. Add regression coverage for skewed timestamps and explicit getSession config filtering behavior. Made-with: Cursor
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VertexAiSessionService.getSession()to stop pre-filtering events against sessionupdateTime.listEvents()and only apply explicitGetSessionConfigfilters.updateTime.Why
Issue #1173 reports that
getSession()can silently drop the most recent event(s) (notably in HITL resume flows) because it compared:updateTimeEvent.timestamp()Those clocks can drift, so valid latest events were filtered out.
What changed
In
core/src/main/java/com/google/adk/sessions/VertexAiSessionService.java:updateTime-based pre-filter infilterEvents(...).numRecentEventsafterTimestamp(inclusive behavior via!isBefore).In
core/src/test/java/com/google/adk/sessions/VertexAiSessionServiceTest.java:getSession_clockSkewWithUpdateTime_doesNotDropRecentEventsgetSession_afterTimestamp_filtersAtOrAfterThresholdgetSession_numRecentEvents_returnsLatestEventsevent.timestamp > session.updateTime).Validation
./mvnw -pl core -Dtest=VertexAiSessionServiceTest test./mvnw testfails due to existing unrelated test/build issues outside the files changed in this PR.Issue
Closes #1173