Avoid NaN gradients for balanced routing losses - #218
Merged
jpuigcerver merged 1 commit intoSep 11, 2026
Merged
jpuigcerver merged 1 commit into
jpuigcerver merged 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The squared coefficient-of-variation losses differentiate through
std, producing NaN gradients at perfectly balanced expert loads. This also affects a zero-initialized router despite its finite loss.Compute the variance directly in the importance and load losses. Cover balanced gates, one-expert routing and router parameter gradients in eager and JIT execution.
Validation: 76 routing, ensemble-routing and MoE tests pass on four virtual CPU devices (two device-count skips). All 22 new regression cases fail on unchanged upstream. Sixty non-balanced value/gradient comparisons match upstream. Syntax and
git diff --checkpass.