Skip to content

C++ modules support - #285

Open
yuriivcs wants to merge 60 commits into
google-ml-infra:mainfrom
yuriivcs:cpp_module
Open

C++ modules support#285
yuriivcs wants to merge 60 commits into
google-ml-infra:mainfrom
yuriivcs:cpp_module

Conversation

@yuriivcs

@yuriivcs yuriivcs commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator

Add Bazel 9 C++ modules configuration for Linux x86_64, Linux aarch64, and cross-compiling between the two.

@yuriivcs yuriivcs changed the title Cpp module C++ modules support Jul 10, 2026
@yuriivcs yuriivcs changed the title C++ modules support [DRAFT] C++ modules support Jul 10, 2026
@yuriivcs yuriivcs changed the title [DRAFT] C++ modules support C++ modules support Jul 16, 2026

@ybaturina ybaturina left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please wait for Richard's review.

@vam-google vam-google left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check this with entire stack of procjects we support, including TF. If it works on all of them, then LGTM

@rickeylev rickeylev left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know the cc toolchain configuration internals that well enough to functionally review this sufficiently, but nothing catches my eye as odd or surprising, so LGTM

@rickeylev rickeylev left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, er -- this sets the default bazel version to 9.1
Is rules_ml_toolchain being tested with other bazel versions somewhere? IIRC, most of the dependent projects are still on bazel 8

@yuriivcs

Copy link
Copy Markdown
Collaborator Author

Ah, er -- this sets the default bazel version to 9.1 Is rules_ml_toolchain being tested with other bazel versions somewhere? IIRC, most of the dependent projects are still on bazel 8

That’s a good question. Right now, we still manually test rules_ml_toolchain against XLA, JAX, and TF before merging, though we should definitely automate this eventually. The internal toolchain tests only cover the basics, I don't think adding tests for different Bazel versions would add much value.
Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants